[indexer] Fix sponsored types displacement.#10150
Merged
Merged
Conversation
mpimenov
reviewed
Dec 25, 2018
Contributor
There was a problem hiding this comment.
Может быть, перепишем на type == internet в этом файле?
Contributor
|
s/inexer/indexer/ in PR and commit |
tatiana-yan
force-pushed
the
fix_sponsored_displacement
branch
from
December 25, 2018 15:43
d69b210 to
e29eeb0
Compare
tatiana-yan
changed the title
Contributor
Author
done |
Contributor
Author
|
JTMAC |
1 similar comment
Contributor
Author
|
JTMAC |
tatiana-yan
force-pushed
the
fix_sponsored_displacement
branch
from
December 28, 2018 12:26
dacabbd to
29ff147
Compare
|
JTANDROID |
tatiana-yan
force-pushed
the
fix_sponsored_displacement
branch
from
January 21, 2019 13:30
29ff147 to
34c9fb3
Compare
Contributor
|
Can one of the admins verify this patch? |
tatiana-yan
force-pushed
the
fix_sponsored_displacement
branch
from
February 11, 2019 15:28
2adc7f0 to
40b2cff
Compare
Contributor
Author
|
JTALL |
tatiana-yan
force-pushed
the
fix_sponsored_displacement
branch
from
February 14, 2019 14:13
85b282e to
c5ea882
Compare
Contributor
Author
|
JTMAC |
tatiana-yan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
При добавлении типа для sponsored объектов была сделана ошибка: они индексируются на низких уровнях зума, в результате чего вытесняют на своём уровне зума вообще всё, даже то что согласно zindex не должны вытеснять (например, станции метро). Для cuisine, wheelchair и surface она была недавно исправлена (#9933). В этом реквесте аналогичное исправление для sponsored.
@maksimandrianov собери пожалуйста несколько карт из этого реквеста или скажи мне где взять hotels.csv. Хочу на более "боевых" данных вручную проверить как всё будет выглядеть и вытесняться: рейтинги и т.п. на это влияют.