fix: duckdb lowerbound#1998
Merged
Merged
Conversation
Add an optional [sql] section to the pyproject.toml which enumerates our SQL dependencies with lower bounds, currently only duckdb >= 1.0. Tell users to obtain SQL dependencies with pip install marimo[sql] instead of pip install duckdb, to ensure they get the correct versions. Update the kernel capabilities check for SQL to check duckdb verison.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Aug 11, 2024
|
|
||
| def __post_init__(self) -> None: | ||
| self.sql = DependencyManager.has_duckdb() | ||
| if DependencyManager.has_duckdb(): |
Contributor
There was a problem hiding this comment.
I wonder if we could pass the version as an argument to this call. It could provide a better warning too or suggestion to upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional [sql] section to the pyproject.toml which enumerates our SQL dependencies with lower bounds, currently only
duckdb >= 1.0.Tell users to obtain SQL dependencies with pip install marimo[sql] instead of pip install duckdb, to ensure they get the correct versions.
Update the kernel capabilities check for SQL to check duckdb verison.
Fixes a bug in which we'd enable SQL support even though users were using incompatible versions of duckdb, causing the kernel to crash.