fix: check frontend's app matches server's app in run mode#449
Merged
Conversation
This change makes the server token in run mode a hash of the code, to prevent frontends made for one app from trying to instantiate on a server serving a different app. This still allows frontends to connect to a server that died and came back as long as the server is serving the same app.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
commented
Dec 12, 2023
Comment on lines
+417
to
+423
| else: | ||
| # Because run-mode is read-only, all that matters is that | ||
| # the frontend's app matches the server's app. | ||
| assert app is not None | ||
| self.server_token = str( | ||
| hash("".join(code for code in app._codes())) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is the main change
mscolnick
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the server token in run mode a hash of the code, to prevent frontends made for one app from trying to instantiate on a server serving a different app. This still allows frontends to connect to a server that died and came back as long as the server is serving the same app.