Skip to content

fix: dont import typing extensions ...#673

Merged
akshayka merged 1 commit into
mainfrom
aka/fix-another-typing-extensions-import
Jan 27, 2024
Merged

fix: dont import typing extensions ...#673
akshayka merged 1 commit into
mainfrom
aka/fix-another-typing-extensions-import

Conversation

@akshayka

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jan 27, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 5:16pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 5:16pm

@codecov

codecov Bot commented Jan 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c4a0f43) 69.38% compared to head (344e2f3) 69.36%.

Files Patch % Lines
marimo/_server/api/lifespans.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   69.38%   69.36%   -0.02%     
==========================================
  Files         139      139              
  Lines        7065     7067       +2     
  Branches     1427     1428       +1     
==========================================
  Hits         4902     4902              
- Misses       1910     1911       +1     
- Partials      253      254       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akshayka
akshayka merged commit 30446ec into main Jan 27, 2024
@akshayka
akshayka deleted the aka/fix-another-typing-extensions-import branch January 27, 2024 17:18
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant