Skip to content

docs: maintainer approval in contributing#9153

Merged
akshayka merged 5 commits intomainfrom
aka/contributing
Apr 13, 2026
Merged

docs: maintainer approval in contributing#9153
akshayka merged 5 commits intomainfrom
aka/contributing

Conversation

@akshayka
Copy link
Copy Markdown
Contributor

This pull request adds a section on when to obtain maintainer approval for a PR, and why.

A section on when to obtain maintainer approval for a PR and why.
Copilot AI review requested due to automatic review settings April 12, 2026 16:37
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Apr 13, 2026 4:22pm

Request Review

@akshayka akshayka changed the title Contributing: maintainer approval docs: maintainer approval in contributing Apr 12, 2026
@akshayka akshayka added the documentation Improvements or additions to documentation label Apr 12, 2026
@akshayka akshayka requested a review from manzt April 12, 2026 16:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the contributor workflow documentation by introducing explicit guidance on when “maintainer approval” is required before submitting substantial PRs, and provides rationale for that policy.

Changes:

  • Adds a new “Maintainer approval” section describing what constitutes a substantial change and how to seek approval.
  • Adds a checklist item linking to the new approval section.
  • Adjusts the opening/contribution guidance text.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
akshayka and others added 2 commits April 12, 2026 09:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
manzt
manzt previously approved these changes Apr 13, 2026
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Trevor Manz <trevor.j.manz@gmail.com>
@akshayka akshayka merged commit 40614fb into main Apr 13, 2026
28 checks passed
@akshayka akshayka deleted the aka/contributing branch April 13, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants