Skip to content

Revise docker setup instructions#928

Merged
rocky merged 4 commits intomasterfrom
docker-doc-update
Oct 3, 2020
Merged

Revise docker setup instructions#928
rocky merged 4 commits intomasterfrom
docker-doc-update

Conversation

@rocky
Copy link
Copy Markdown
Member

@rocky rocky commented Sep 27, 2020

https://hub.docker.com/repository/docker/rockyb/mathics has a more recent docker contrainer for 1.1-dev.

The natlang module isn't built, but I don't think right now that's important. Never let perfection get in the way of progress.

Issue #927 has been created to track remaining steps.

@suhr @GarkGarcia @mmatera If you have docker and get a chance, I'd appreciate it if you could try out the instructions to verify this works.

@GarkGarcia
Copy link
Copy Markdown
Contributor

Cool! It would be nice if forked the repository within our organization (create an "official" repository for this). @poeschko Could you do that?

@GarkGarcia
Copy link
Copy Markdown
Contributor

@suhr @GarkGarcia @mmatera If you have docker and get a chance, I'd appreciate it if you could try out the instructions to verify this works.

I don't use docker at all, can't help with this one.

@mmatera
Copy link
Copy Markdown
Contributor

mmatera commented Sep 27, 2020

@suhr @GarkGarcia @mmatera If you have docker and get a chance, I'd appreciate it if you could try out the instructions to verify this works.

I don't use docker at all, can't help with this one.

Me neither, sorry...

@suhr
Copy link
Copy Markdown
Contributor

suhr commented Sep 27, 2020

Ok, let me try...

@suhr
Copy link
Copy Markdown
Contributor

suhr commented Sep 27, 2020

Unable to find image 'rockyb:mathics' locally
docker: Error response from daemon: pull access denied for rockyb, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.

@poeschko
Copy link
Copy Markdown
Member

I could certainly create a repo – perhaps mathics-docker?

But just to make a deliberate decision: Should it really be a separate repo? Could it not just be a Dockerfile in the main Mathics repo? That's e.g. how Sage seems to do it (after they had a separate repo before).

@suhr
Copy link
Copy Markdown
Contributor

suhr commented Sep 27, 2020

@rocky Replacing rockyb:mathics with rockyb/mathics fixes the issue.

@GarkGarcia
Copy link
Copy Markdown
Contributor

But just to make a deliberate decision: Should it really be a separate repo? Could it not just be a Dockerfile in the main Mathics repo? That's e.g. how Sage seems to do it (after they had a separate repo before).

I agree. This should be in the main repo.

@rocky
Copy link
Copy Markdown
Member Author

rocky commented Sep 27, 2020

Ok. If someone wants to take things from here and put in the main repo, that would be awesome!

(Note that there is the top-level dockerfile as well as a docker directory)

I have done a quick and dirty job. See #927 for what remains.

@rocky
Copy link
Copy Markdown
Member Author

rocky commented Sep 27, 2020

@rocky Replacing rockyb:mathics with rockyb/mathics fixes the issue.

@suhr Thanks for trying and thanks for the feedback. It looks like there will be other changes, so I guess this fix will be incorporated into the other changes.

Also on the next docker update, I'll do the additional steps to eliminate the missing natlang module message problem.

https://hub.docker.com/repository/docker/rockyb/mathics has a more
recent docker contrainer for 1.1-dev.

The natlang module isnt' built, but I don't think right now that's
important. Never let perfection get in the way of progress.

Issue #927 has been created to track remaining steps.
Docker configuration is now in this repository. (It is still a little
rough though)

dockerhub location is now in the mathicsorg namespace, not rockyb.

Instructions have been revised.

pymathics module "natlang" has been pulled from being assumed it is pre-built.
@rocky rocky changed the title Revise docker setup instructions WIP: Revise docker setup instructions Sep 27, 2020
@rocky
Copy link
Copy Markdown
Member Author

rocky commented Sep 27, 2020

@poeschko I am part of the mathicsorg organiation, but apparently I don't have permission to create something new. The "Create Repository" Blue button is slightly faded out to indicate I can't push that.

I've also updated the docker image to remove the natlang module problem. So maybe in the short term copy what's in rockyb/mathics over here and then things will be good. Or give me access to create a docker container.

@suhr I've corrected the doc to change : to -, but of course the namespace currently is still rockyb while the docs have been updated to reflect mathicsorg. I am assuing that if you ignore that for now until it really gets to mathicsorg things will be fine or better than before

all - this is still a little bit hacky. The code between the docker config and the package config (and various CI's) really should be DRY'd and not duplicated.

Probably building instructions should be updated too. Probably in the Wiki somehwere.

However this is more time on this than I can (or should have) spent on it since I need to do other things.

@rocky rocky changed the title WIP: Revise docker setup instructions Revise docker setup instructions Sep 27, 2020
@poeschko
Copy link
Copy Markdown
Member

I created the repo https://hub.docker.com/repository/docker/mathicsorg/mathics and gave you Admin access to it, @rocky. Let me know if there's anything else I can do.

@rocky
Copy link
Copy Markdown
Member Author

rocky commented Sep 27, 2020

I created the repo https://hub.docker.com/repository/docker/mathicsorg/mathics and gave you Admin access to it, @rocky. Let me know if there's anything else I can do.

This worked. Thanks!

https://hub.docker.com/r/mathicsorg/mathics now has the docker image and you should be able to docker pull mathicsorg/mathics or run as per the instructions in this updated README.rst.

The docker image in rockyb has been removed to reduce potential confusion.

@suhr wanna try again?

@suhr
Copy link
Copy Markdown
Contributor

suhr commented Sep 28, 2020

Yes it works.

@rocky rocky merged commit 6099bba into master Oct 3, 2020
@rocky rocky deleted the docker-doc-update branch October 7, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants