Conversation
|
Cool! It would be nice if forked the repository within our organization (create an "official" repository for this). @poeschko Could you do that? |
I don't use docker at all, can't help with this one. |
Me neither, sorry... |
|
Ok, let me try... |
|
|
I could certainly create a repo – perhaps But just to make a deliberate decision: Should it really be a separate repo? Could it not just be a |
|
@rocky Replacing |
I agree. This should be in the main repo. |
|
I have done a quick and dirty job. See #927 for what remains. |
@suhr Thanks for trying and thanks for the feedback. It looks like there will be other changes, so I guess this fix will be incorporated into the other changes. Also on the next docker update, I'll do the additional steps to eliminate the missing natlang module message problem. |
39ffc3b to
de2e4bd
Compare
https://hub.docker.com/repository/docker/rockyb/mathics has a more recent docker contrainer for 1.1-dev. The natlang module isnt' built, but I don't think right now that's important. Never let perfection get in the way of progress. Issue #927 has been created to track remaining steps.
Docker configuration is now in this repository. (It is still a little rough though) dockerhub location is now in the mathicsorg namespace, not rockyb. Instructions have been revised. pymathics module "natlang" has been pulled from being assumed it is pre-built.
de2e4bd to
6ec25fa
Compare
|
@poeschko I am part of the mathicsorg organiation, but apparently I don't have permission to create something new. The "Create Repository" Blue button is slightly faded out to indicate I can't push that. I've also updated the docker image to remove the natlang module problem. So maybe in the short term copy what's in rockyb/mathics over here and then things will be good. Or give me access to create a docker container. @suhr I've corrected the doc to change all - this is still a little bit hacky. The code between the docker config and the package config (and various CI's) really should be DRY'd and not duplicated. Probably building instructions should be updated too. Probably in the Wiki somehwere. However this is more time on this than I can (or should have) spent on it since I need to do other things. |
|
I created the repo https://hub.docker.com/repository/docker/mathicsorg/mathics and gave you Admin access to it, @rocky. Let me know if there's anything else I can do. |
This worked. Thanks! https://hub.docker.com/r/mathicsorg/mathics now has the docker image and you should be able to The docker image in @suhr wanna try again? |
|
Yes it works. |
d4b5f5e to
757bc5b
Compare
https://hub.docker.com/repository/docker/rockyb/mathics has a more recent docker contrainer for 1.1-dev.
The natlang module isn't built, but I don't think right now that's important. Never let perfection get in the way of progress.
Issue #927 has been created to track remaining steps.
@suhr @GarkGarcia @mmatera If you have docker and get a chance, I'd appreciate it if you could try out the instructions to verify this works.