Skip to content

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 20, 2021

There's already special-casing for polar plots in bar() (using the same
_interpolation_steps = 100); it seems reasonable to use the same
approach for axvspan (e.g. polar(); axvspan(0, pi/4)).

It seems like making axhspan work (basically drawing full rings) is less
easy, but there's an easy enough workaround
(polar(); bar(0, bottom=1, height=1, width=2*pi)) as the "x" (theta)
extent is actually known in that case.

plt.polar(); plt.axvspan(np.pi/4, np.pi/2)
before:
old
after:
new

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

There's already special-casing for polar plots in bar() (using the same
`_interpolation_steps = 100`); it seems reasonable to use the same
approach for axvspan (e.g. `polar(); axvspan(0, pi/4)`).

It seems like making axhspan work (basically drawing full rings) is less
easy, but there's an easy enough workaround
(`polar(); bar(0, bottom=1, height=1, width=2*pi)`) as the "x" (theta)
extent is actually known in that case.
@QuLogic QuLogic merged commit 7a12f32 into matplotlib:master Apr 20, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Apr 20, 2021
@anntzer anntzer deleted the axvspp branch April 20, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants