axvline()/axvspan() should not update r limits in polar plots. #20032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Apr 20, 2021
| if patch.get_data_transform() != self.transData: | ||
| patch_to_data = (patch.get_data_transform() - | ||
| self.transData) | ||
| xys = patch_to_data.transform(xys) |
There was a problem hiding this comment.
note that get_patch_transform() + get_data_transform() == get_transform() == patch_trf
timhoffm
approved these changes
Apr 23, 2021
Special-casing a check for get_xaxis_transform() is a bit ugly and definitely not general, but fixes the main issue at hand... (Shortening the variable names to _trf mostly helps avoiding line continuations, and I also made the layout in _update_line_limits and _update_patch_limits closer to one another; the main relevant change feature-wise is just the `if name != "rectilinear"` blocks.)
anntzer
force-pushed
the
polar-xaxis-trf-datalim
branch
from
801ce67 to
6731f2c
Compare
jklymak
reviewed
May 19, 2021
| return | ||
|
|
||
| updatex, updatey = line_trf.contains_branch_seperately(self.transData) | ||
| if self.name != "rectilinear": |
There was a problem hiding this comment.
We store the projection in a public attribute ax.name? That seems ripe for abuse? I took a quick look around and this is not used a lot. Is this actually how we tell what the projection is?
There was a problem hiding this comment.
This is at least how Line2D.recache() (which, although slightly obscure, is very often indirectly called in practice) does the same check. It's not clear either to me how else we could check that...
jklymak
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special-casing a check for get_xaxis_transform() is a bit ugly and
definitely not general, but fixes the main issue at hand...
(Shortening the variable names to _trf mostly helps avoiding line
continuations, and I also made the layout in _update_line_limits and
_update_patch_limits closer to one another; the main relevant change
feature-wise is just the
if name != "rectilinear"blocks.)"Fixes" (effectively) #20030 by adding a special case, but this is not a general solution
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).