fix: uses scatter markers with facecolor = 'none' #30671
+34
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the bug described in #24404, in which the
scatterfunction did not respect thefacecolors='none'option, resulting in filled markers even when the user only wanted an outline. Since there are logs reporting the possibility that thecparameter inscatter()might fail to overridefacecolor, this implementation accounts for this possibility.Why is this change necessary?
The
facecolors='none'option should produce hollow (unfilled) markers, but the current behavior ignored this setting, filling the markers with the default color.What problem does it solve? Allows
plt.scatter(..., facecolors='none')to correctly draw empty markers—that is, with only the outline visible, as expected and as per the documentation.What is the reason for this implementation?
The implementation adjusts the internal handling of
facecolorsinPathCollection, ensuring that the valuenoneis interpreted correctly and the fill is omitted.Minimal Example
Old output:

Result with modification:

Operating system
windows
Matplotlib Version
latest
Python version
3.11