-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix array alpha to multiply (not replace) existing RGBA alpha #30795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FazeelUsmani
wants to merge
2
commits into
matplotlib:main
Choose a base branch
from
FazeelUsmani:fix-rgb-array-alpha-26092
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−9
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| *alpha* parameter handling on images | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| When passing and array to ``imshow(..., alpha=...)``, the parameter was silently ignored | ||
| if the image data was a RGB or RBGA image or if :rc:`interpolation_state` | ||
| resolved to "rbga". | ||
| When passing an array to ``imshow(..., alpha=...)``, the parameter was silently ignored | ||
| if the image data was a RGB or RGBA image or if :rc:`interpolation_stage` | ||
| resolved to "rgba". | ||
|
|
||
| This is now fixed, and the alpha array overwrites any previous transparency information. | ||
| This is now fixed. For RGB images, the alpha array is used directly as the alpha channel. | ||
| For RGBA images, the alpha array is multiplied with the existing alpha channel, consistent | ||
| with how scalar alpha values are handled. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not quite right - for RGBA the alpha parameter replaced the image alpha channel. So alpha was not ignored.