Skip to content

Bump the uniffi-bindgen-go version - #257

Merged
richvdh merged 1 commit into
mainfrom
poljar/bump-uniffi-bindgen-go
Aug 3, 2026
Merged

Bump the uniffi-bindgen-go version#257
richvdh merged 1 commit into
mainfrom
poljar/bump-uniffi-bindgen-go

Conversation

@poljar

@poljar poljar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR bumps uniffi-bindgen-go to include the following fix: NordSecurity/uniffi-bindgen-go@f510413.

This fixes errors on the Rust side raising panics on the Go side, like we saw in #245.

@richvdh richvdh linked an issue Aug 3, 2026 that may be closed by this pull request
@richvdh

richvdh commented Aug 3, 2026

Copy link
Copy Markdown
Member

Great, thanks. Can we cherry-pick 0b21e1f in here, too?

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@poljar

poljar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Great, thanks. Can we cherry-pick 0b21e1f in here, too?

Not sure why I created a stack, but ok: #258

@richvdh richvdh changed the title Bump the uniff-bindgen-go version Bump the uniffi-bindgen-go version Aug 3, 2026
@richvdh

richvdh commented Aug 3, 2026

Copy link
Copy Markdown
Member

As if to underline your point, this flaked with matrix-org/matrix-rust-sdk#5068. Re-running...

@poljar

poljar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

As if to underline your point, this flaked with matrix-org/matrix-rust-sdk#5068. Re-running...

And both, tests and Rust-only tests, failed on #258.

@richvdh
richvdh merged commit 01b7401 into main Aug 3, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests flaking due to panic: EOF

2 participants