This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Handle exceptions thrown in handling remote device list updates#2189
Merged
erikjohnston merged 3 commits intodevelopfrom May 5, 2017
Merged
Handle exceptions thrown in handling remote device list updates#2189erikjohnston merged 3 commits intodevelopfrom
erikjohnston merged 3 commits intodevelopfrom
Conversation
erikjohnston
changed the title
Member
Author
|
Relatedly, #2190 should make this less common |
Member
Author
|
(This shouldn't actually be a functional change, since we catch exceptions a layer up too. This just logs them in the right place and doesn't spam the logs with exceptions for |
richvdh
approved these changes
May 5, 2017
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
a comment explaining why it's better to abort than to carry on with the delta wouldn't hurt. Otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.