test: add BVT regression for IN subquery regexp misparsing (#23105) - #24464
Merged
mergify[bot] merged 5 commits intoMay 20, 2026
Merged
Conversation
…gin#23105) The bug (IN subquery returning "error parsing regexp: missing closing ]") was fixed by matrixorigin#23630 which corrected regex metacharacter escaping in LIKE evaluation. Add regression coverage so it stays fixed. Fixes matrixorigin#23105 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
heni02
approved these changes
May 20, 2026
Contributor
Merge Queue Status
This pull request spent 59 minutes 10 seconds in the queue, including 58 minutes 49 seconds running CI. Required conditions to merge
|
ULookup
pushed a commit
to ULookup/matrixone
that referenced
this pull request
May 26, 2026
…gin#23105) (matrixorigin#24464) Add BVT regression test for matrixorigin#23105 — `SELECT * FROM t WHERE id IN (SELECT id FROM t WHERE 1=0)` used to produce `error parsing regexp: missing closing ]: [` instead of returning an empty result. The root cause was fixed by matrixorigin#23630 (regex metacharacter escaping in LIKE evaluation, merged 2026-02-02). This PR adds regression coverage so it stays fixed: - IN subquery with empty result set - IN subquery with non-empty result set - VARCHAR data containing regex metacharacters (`[`, `+`) - LIKE pattern containing `[` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Approved by: @heni02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23105
What this PR does / why we need it:
Add BVT regression test for #23105 —
SELECT * FROM t WHERE id IN (SELECT id FROM t WHERE 1=0)used to produceerror parsing regexp: missing closing ]: [instead of returning an empty result.The root cause was fixed by #23630 (regex metacharacter escaping in LIKE evaluation, merged 2026-02-02). This PR adds regression coverage so it stays fixed:
[,+)[🤖 Generated with Claude Code