Skip to content

fix: make tasks a non-reserved mysql keyword - #24485

Merged
mergify[bot] merged 4 commits into
matrixorigin:mainfrom
iamlinjunhong:m-24479
May 20, 2026
Merged

fix: make tasks a non-reserved mysql keyword#24485
mergify[bot] merged 4 commits into
matrixorigin:mainfrom
iamlinjunhong:m-24479

Conversation

@iamlinjunhong

@iamlinjunhong iamlinjunhong commented May 20, 2026

Copy link
Copy Markdown
Contributor

Add an incremental keyword policy test so future non-reserved keywords must be accepted as identifiers or explicitly exempted.

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #24479

What this PR does / why we need it:

fix: make tasks a non-reserved mysql keyword

@iamlinjunhong
fix: make tasks a non-reserved mysql keyword
4360192 
Add an incremental keyword policy test so future non-reserved keywords must be accepted as identifiers or explicitly exempted.
@qodo-code-review

qodo-code-review Bot commented May 20, 2026

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@iamlinjunhong
iamlinjunhong requested a review from XuPeng-SH May 20, 2026 03:48
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label May 20, 2026
@mergify mergify Bot added the queued label May 20, 2026
@mergify

mergify Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-05-20 10:29 UTC · Rule: main
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-05-20 13:00 UTC · at 5460238694a294b8b224f23f278063044daf1ad4 · squash

This pull request spent 2 hours 30 minutes 42 seconds in the queue, including 58 minutes 35 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-neutral = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-skipped = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / SCA Test on Ubuntu/x86
    • check-neutral = Matrixone CI / SCA Test on Ubuntu/x86
    • check-skipped = Matrixone CI / SCA Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / UT Test on Ubuntu/x86
    • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
    • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-neutral = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-skipped = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Utils CI / Coverage
    • check-neutral = Matrixone Utils CI / Coverage
    • check-skipped = Matrixone Utils CI / Coverage

@mergify
mergify Bot merged commit df3dbc7 into matrixorigin:main May 20, 2026
23 of 24 checks passed
@mergify mergify Bot removed the queued label May 20, 2026
ULookup pushed a commit to ULookup/matrixone that referenced this pull request May 26, 2026
@iamlinjunhong @ULookup
fix: make tasks a non-reserved mysql keyword (matrixorigin#24485)
74643c8 
fix: make tasks a non-reserved mysql keyword

Approved by: @XuPeng-SH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

Assignees

No one assigned

Labels

size/M Denotes a PR that changes [100,499] lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamlinjunhong @XuPeng-SH @matrix-meow