fix(plan): support nested correlated subqueries - #24537
Merged
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
ck89119
changed the title
aunjgr
approved these changes
May 22, 2026
aunjgr
left a comment
aunjgr
left a comment
Contributor
There was a problem hiding this comment.
Review: nested correlated subqueries
Approve.
The deep-correlation handling is constrained to supported subquery types, guards unsafe pull-up cases that still contain inner columns, and appends lifted deep-correlated filters in a controlled way after mark join creation. Added tests cover EXISTS/NOT EXISTS/IN/NOT IN/ANY/ALL nested correlated cases plus an explicit guarded error path.
No blocking issue found.
matrix-meow
added
size/L
Contributor
Merge Queue Status
This pull request spent 59 minutes 5 seconds in the queue, including 58 minutes 37 seconds running CI. Required conditions to merge
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23110
What this PR does / why we need it:
ANYandALLby allowing their deep correlated predicates to be pulled up.ANY/ALLmark joins, matching the existingEXISTS/INhandling.ANY/ALLsubqueries.Validation:
go test ./pkg/sql/plan -run TestSubQuery -count=1go test ./pkg/sql/plan -count=1makemake static-checkgit diff --checknpx markdownlint-cli CLAUDE_TODO_2026-05-22.mdmo-service; focused execution of the new BVT block returned expected rows.