test: cover ODKU unique-key conflict with auto increment - #24569
Merged
mergify[bot] merged 15 commits intoJun 5, 2026
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
heni02
approved these changes
May 26, 2026
Contributor
Merge Queue Status
This pull request spent 38 minutes 5 seconds in the queue, with no time running CI. Waiting for
All conditions
ReasonPull request #24569 has been dequeued Queue conditions are not satisfied:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
approved these changes
Jun 3, 2026
Contributor
Merge Queue Status
This pull request spent 49 minutes 23 seconds in the queue, with no time running CI. ReasonPull request #24569 has been dequeued Queue conditions are not satisfied:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
Merge Queue Status
This pull request spent 1 hour 3 minutes 48 seconds in the queue, including 1 hour 2 minutes 50 seconds running CI. Required conditions to merge
|
XuPeng-SH
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Closes #23145
issue #23145
What this PR does / why we need it:
Adds BVT coverage for the current MatrixOne behavior of
INSERT ... ON DUPLICATE KEY UPDATEon anAUTO_INCREMENTprimary-key table when the conflict is on a secondaryUNIQUEkey.Changes:
id AUTO_INCREMENT PRIMARY KEY,code UNIQUE, and a counter column.Validation:
git diff --checkgo test ./pkg/sql/parsers -run 'TestSplitSqlBySemicolon|TestParseSQLs|TestParse' -count=1go test ./pkg/sql/parsers/dialect/mysql -run TestDebug -count=1Note: I could not run the BVT locally because
mo-testeris not available in this workspace.