fix(main): preserve txn write order after workspace merge - #24576
Merged
mergify[bot] merged 2 commits intoMay 26, 2026
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
mergify
Bot
added
kind/bug
aptend
force-pushed
the
cp/main-txn-write-order-secondary-index-eob
branch
from
May 25, 2026 10:31
f85a19b to
853048a
Compare
aptend
changed the title
gouhongshen
approved these changes
May 26, 2026
XuPeng-SH
approved these changes
May 26, 2026
Contributor
Merge Queue Status
This pull request spent 1 hour 12 minutes 17 seconds in the queue, including 1 hour 11 minutes 49 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #24566
What this PR does / why we need it:
Preserve txn write order when merging txn workspaces by compacting nil write entries stably. The old swap-with-tail removal could reorder catalog create writes and dependent table/S3 writes, which could make DN apply data before the hidden index table catalog entry exists.
Also improves the TAE write path error for missing relation IDs so it reports a missing table instead of formatting the table ID/name as an unknown database.
Tests: