fix(frontend): support human-readable datetime strings in MO_TS table hint - #24629
Merged
mergify[bot] merged 17 commits intoJun 2, 2026
Merged
Conversation
… hint
When `{MO_TS = '2024-01-01 00:00:00'}` was used, it only accepted
the internal debug timestamp format (`PhysicalTime-LogicalTime`).
Now it tries to parse human-readable datetime strings first,
falling back to the debug format if that fails.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
matrix-meow
added
size/S
gouhongshen
approved these changes
Jun 1, 2026
heni02
approved these changes
Jun 2, 2026
## What type of PR is this? - [ ] API-change - [x] BUG - [ ] Improvement - [ ] Documentation - [ ] Feature - [x] Test and CI - [ ] Code Refactoring ## Which issue(s) this PR fixes: issue matrixorigin#24122 issue matrixorigin#21685 ## What this PR does / why we need it: Adds BVT coverage for two existing features: - SQL Task string literal preservation: verifies string literals in `WHEN` gate conditions and SQL task bodies are preserved in `mo_task.sql_task` and execute with the expected semantics. - `ALTER USER ... LOCK/UNLOCK`: verifies lock/unlock status transitions for sys tenant users and normal tenant users. - Account restore coverage for normal tenants: verifies locked normal tenant users and normal tenant admin users restore to the snapshot lock status.
use cuVS C++ library for Kmeans, Cagra, Ivfflat, brute force, ivfpq integrate pairwise distance to sql function L2Distance, InnerProduct,...etc. GPU Brute force index for CentriodX JOIN Parameter "gpu_mode" with valid values [0|1]. With CPU build, default value is 0. Wtih GPU build, default value is 1. Approved by: @ouyuanning, @aunjgr, @heni02, @fengttt, @gouhongshen, @LeftHandCold, @iamlinjunhong, @XuPeng-SH
补充函数 ``` JSON_ARRAY JSON_OBJECT JSON_TYPE JSON_VALID JSON_LENGTH JSON_KEYS JSON_PRETTY JSON_SCHEMA_VALID JSON_SCHEMA_VALID_REPORT JSON_VALUE ``` Approved by: @aunjgr, @heni02, @XuPeng-SH
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Collaborator
Author
|
@fengttt @iamlinjunhong @LeftHandCold @aunjgr @ouyuanning Please review this PR. |
Collaborator
Author
aunjgr
approved these changes
Jun 2, 2026
aunjgr
left a comment
aunjgr
left a comment
Contributor
There was a problem hiding this comment.
Clean fix. The human-readable datetime path is added before the debug-format fallback, matching the ATTIMESTAMPTIME branch's pattern:
time.Parse("2006-01-02 15:04:05.999999999", ...)first → producesPhysicalTimedirectly- Falls back to
timestamp.ParseTimestamp(...)forPhysicalTime-LogicalTimedebug format tsNano <= 0correctly rejects sub-epoch timestamps (physical_time=0 is an invalid sentinel in TAE)
Error propagation via named-return err is correct in both branches. LGTM.
Contributor
Merge Queue Status
This pull request spent 1 hour 15 minutes 24 seconds in the queue, including 1 hour 13 minutes 45 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24554
What this PR does / why we need it:
When
{MO_TS = '2024-01-01 00:00:00'}was used, it only accepted the internal debug timestamp format (PhysicalTime-LogicalTime), causinginvalid debug timestamp stringerrors for human-readable datetime strings. This PR makes the MO_TS hint try to parse human-readable datetime strings first, falling back to the debug format if parsing fails, matching the behavior of the existing{TIMESTAMP = '...'}hint.Special notes for your reviewer:
The change is isolated to the
ATMOTIMESTAMPstring-literal branch inResolveTsHint(). It reuses the sametime.Parsepattern already present in theATTIMESTAMPTIMEbranch.🤖 Generated with Claude Code