fix data branch privilege model - #24875
Merged
mergify[bot] merged 5 commits intoJun 9, 2026
Merged
Conversation
mergify
Bot
added
kind/bug
fengttt
approved these changes
Jun 8, 2026
XuPeng-SH
approved these changes
Jun 9, 2026
Contributor
Merge Queue Status
This pull request spent 1 hour 4 minutes 25 seconds in the queue, including 1 hour 3 minutes 43 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24840
What this PR does / why we need it:
This PR fixes the systemic privilege model for
DATA BRANCHstatements so branch operations require the same privileges as the ordinary SQL reads and writes they logically perform.Main changes:
DATA BRANCHprivilege resolver for create/delete/diff/merge/pick statements.DATA BRANCH CREATE TABLEwith sourceSELECTplus destinationCREATE TABLE.DATA BRANCH CREATE DATABASEwithCREATE DATABASEplus source table/view read checks, sharing clone database source resolution with execution.DATA BRANCH DIFFwithSELECTon both inputs.DATA BRANCH MERGEandPICKwith source/destination reads plus destinationINSERT/UPDATE/DELETE.DATA BRANCH DELETEfrom dropping ordinary non-branch objects by validating active branch metadata before DDL.TO ACCOUNT.TO ACCOUNT, subscription sources, and destructive delete safety for empty/view-only/sequence-only/mixed databases.Validation:
go test ./pkg/frontendmake buildmo-tester -m genrs -i branch_privilegemo-tester -i branch_privilege(TOTAL:249 SUCCESS:249 FAILED:0)git diff --check