fix-qcloud-cos-retryable-status - #24999
Merged
mergify[bot] merged 3 commits intoJun 17, 2026
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
requested changes
Jun 16, 2026
XuPeng-SH
left a comment
XuPeng-SH
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes for one retry-classification gap.
This PR adds COS-specific retry handling for 429 / 502 / 503 / 504, but it still leaves 500 Internal Server Error non-retryable. Since MatrixOne routes QCloud operations through DoWithRetry(..., IsRetryableError), that means transient COS 500s will still fail immediately instead of retrying.
I think http.StatusInternalServerError should be included in the retryable COS status set, and the new status-based test should cover 500 as well.
XuPeng-SH
approved these changes
Jun 16, 2026
Contributor
Merge Queue Status
This pull request spent 1 hour 25 minutes 30 seconds in the queue, with no time running CI. Waiting for
All conditions
ReasonThe pull request #24999 has been manually updated Failing checks:
HintIf you want to requeue this pull request, you can post a |
jiangxinmeng1
force-pushed
the
fix-qcloud-cos-retryable-status
branch
from
June 16, 2026 08:21
fcd1480 to
71ce0f7
Compare
Contributor
Merge Queue Status
This pull request spent 1 hour 1 minute 35 seconds in the queue, with no time running CI. Waiting for
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks:
HintYou may have to fix your CI before adding the pull request to the queue again. |
Contributor
Merge Queue Status
This pull request spent 1 hour 3 minutes 53 seconds in the queue, including 1 hour 3 minutes 32 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24998
What this PR does / why we need it:
Fix qcloud cos retryable status