fix(show7): replace sleep with @wait_expect for statement_info readiness - #25036
Merged
Conversation
Use mo-tester @wait_expect(2, 30) polling instead of a fixed sleep(15) to wait for system.statement_info to be populated. Fixes flaky BVT failure in Multi-CN PROXY mode where async audit pipeline exceeds 15s. Fixes matrixorigin#25018
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky BVT (dml/show/show7.sql) by replacing a fixed sleep(15) wait with mo-tester’s polling-based @wait_expect, improving reliability in Multi-CN PROXY mode where system.statement_info is populated asynchronously.
Changes:
- Remove the one-shot
sleep(15)-based readiness gate forsystem.statement_info. - Add
-- @wait_expect(2, 30)to poll for the expectedhas_data=1result (interval 2s, timeout 30s). - Regenerate
show7.resultto reflect the updated execution/output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/distributed/cases/dml/show/show7.sql | Replaces blind sleep with @wait_expect polling before asserting statement_info has data. |
| test/distributed/cases/dml/show/show7.result | Updates expected output after removing the sleep query and regenerating results. |
heni02
approved these changes
Jun 18, 2026
XuPeng-SH
approved these changes
Jun 18, 2026
Contributor
Merge Queue Status
This pull request spent 1 hour 2 minutes 45 seconds in the queue, including 1 hour 2 minutes 28 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
fixes #25018
What this PR does / why we need it:
show7.sqlused a fixedsleep(15)to wait forsystem.statement_infoto be populated before assertingselect count(*) > 0. In Multi-CN PROXY mode the async audit pipeline can exceed 15s under CI pressure, causing the BVT to flake (the assertion at the next line gets0instead of1).Replace the blind sleep with mo-tester native
-- @wait_expect(2, 30):1.@wait_expectin BVT; mo-tester implementation reviewed (no infinite-loop / statement-leak / session hazard)..resultregenerated viarun.sh -m genrs(type headers preserved).Verification