fix load data for year columns - #25112
Merged
mergify[bot] merged 3 commits intoJun 25, 2026
Merged
Conversation
jiangxinmeng1
requested review from
aunjgr,
heni02 and
ouyuanning
as code owners
June 24, 2026 01:58
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
heni02
approved these changes
Jun 24, 2026
aunjgr
approved these changes
Jun 24, 2026
aunjgr
left a comment
aunjgr
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean fix — adds YEAR type to the LOAD DATA CSV parser. Unit tests + BVT coverage.
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 1 hour 35 minutes 33 seconds in the queue, including 1 hour 35 minutes 10 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25066
What this PR does / why we need it:
Fixes LOAD DATA CSV handling for YEAR columns by parsing values into types.MoYear instead of falling through to the unsupported type path.
Adds unit coverage for YEAR parsing in LOAD DATA and a distributed regression case that loads a CSV into a table with a YEAR column.