fix(StateMediator): Double StopEvent timeout to 60s - #1067
Open
runkelcorey wants to merge 1 commit into
Open
Conversation
runkelcorey
marked this pull request as draft
August 13, 2026 14:33
runkelcorey
marked this pull request as ready for review
August 13, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Doubles
sync_timeoutfor StopEvents in the hopes (gulp) of quashing API-AAR. This is a coarse knob to turn but I think it's premature to try other options. Since #1065, all incremental updates take less than 2s to process but the initial load ofStopEventcan take upwards of 10s. It seems like the startup of the supervision tree imposes additional performance impacts on this loading process and, yesterday,devexperienced API-AAR once again.My question for the reviewer is: is there a better way to only adjust the initial timeout? I don't want to enable this to silently take 50s on incremental loads. After investigating, I don't see a backwards compatible way to do this: timeout options are passed by a private function in S3Mediator that's used for initial as well as recurring updates. The equivalent function in Mediator is never modified and this would be a break with the existing design pattern (plus, redundant code for the CR crowding case).