Skip to content

fix(shasum): version 1.1.4 - #1558

Merged
tcely merged 3 commits into
mainfrom
tcely-shasum-updates
Aug 20, 2026
Merged

fix(shasum): version 1.1.4#1558
tcely merged 3 commits into
mainfrom
tcely-shasum-updates

Conversation

@tcely

@tcely tcely commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
  • argument safety
  • remove IOError alias
  • style adjustment for quoting

Previous: #1403


Lint results

shasum_tests.py:
   85:53 UP012 [*] Unnecessary UTF-8 `encoding` argument to `encode`
  169:24 RUF059 Unpacked variable `is_tag` is never used
  223:24 RUF059 Unpacked variable `err` is never used
  254:9  RUF059 Unpacked variable `exit_code` is never used
  273:25 RUF059 Unpacked variable `err` is never used
  290:29 RUF059 Unpacked variable `err` is never used
  300:37 UP012 [*] Unnecessary UTF-8 `encoding` argument to `encode`
  311:25 RUF059 Unpacked variable `err` is never used
  320:23 UP012 [*] Unnecessary UTF-8 `encoding` argument to `encode`
  327:25 RUF059 Unpacked variable `err` is never used
  339:13 SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
  352:9  SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
  368:13 SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
  394:9  RUF059 Unpacked variable `exit_code` is never used
  394:20 RUF059 Unpacked variable `out` is never used
  412:20 RUF059 Unpacked variable `out` is never used
  436:9  RUF059 Unpacked variable `exit_code` is never used
  462:25 RUF059 Unpacked variable `err` is never used
  482:20 RUF059 Unpacked variable `out` is never used
  505:13 RUF059 Unpacked variable `exit_code` is never used
  505:24 RUF059 Unpacked variable `out` is never used
  536:15 RUF059 Unpacked variable `out` is never used
  536:20 RUF059 Unpacked variable `err` is never used

- argument safety
- remove IOError alias
- style adjustment for quoting
@tcely tcely self-assigned this Aug 20, 2026
@tcely
tcely marked this pull request as ready for review August 20, 2026 07:00
@tcely tcely moved this to In Progress in Status Aug 20, 2026
@tcely
tcely requested a review from meeb August 20, 2026 10:43

@meeb meeb left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I mind, but why is this converting " back to ' ?

@github-project-automation github-project-automation Bot moved this from In Progress to Ready in Status Aug 20, 2026
@tcely

tcely commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

Mostly because I dislike when files use both.

@tcely
tcely merged commit 0b1311a into main Aug 20, 2026
7 checks passed
@tcely
tcely deleted the tcely-shasum-updates branch August 20, 2026 12:32
@github-project-automation github-project-automation Bot moved this from Ready to Done in Status Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants