fix(shasum): version 1.1.5 - #1559
Merged
Merged
Conversation
tcely
marked this pull request as ready for review
August 20, 2026 13:43
tcely
force-pushed
the
tcely-shasum-unbuffered
branch
8 times, most recently
from
August 20, 2026 22:43
8a1d846 to
602e72e
Compare
- use unbuffered reads into a memory view - cast the memory view for faster operations - process buffered files first - switch the file_buffer_pool to `queue.SimpleQueue` - reduce the number of tasks sent to `ThreadPoolExecutor` - translate Windows path separators
tcely
force-pushed
the
tcely-shasum-unbuffered
branch
from
August 20, 2026 23:08
602e72e to
fbb4fb0
Compare
meeb
approved these changes
Aug 22, 2026
Owner
|
You just fully re-implementing shasum in Python? |
Collaborator
Author
|
I gave up on the variations between busybox and coreutils and whatever windows/mac are using in various versions a while ago. Since I had decided to implement a verification tool in Python, I then gave it the default behaviors that I wanted with some minimal speed / consistency improvements. These latest changes are about speeding things up and accepting manifest files containing Windows paths. The performance across multiple files has become quite good. I'd consider switching to this tool to be a win for anyone who has to verify files. v1.1.3v1.1.4v1.1.5 |
Owner
|
Thanks! The implementation looks solid and the reasoning is sound. I was mostly just curious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue.SimpleQueueThreadPoolExecutorPrevious: #1558