Skip to content

Add details field to Task class#335

Closed
kuruvasatya wants to merge 1 commit intomeilisearch:mainfrom
kuruvasatya:changeTaskClass
Closed

Add details field to Task class#335
kuruvasatya wants to merge 1 commit intomeilisearch:mainfrom
kuruvasatya:changeTaskClass

Conversation

@kuruvasatya
Copy link
Copy Markdown
Contributor

Pull Request

What does this PR do?

Fixes #331

created new class Details with two fields, and added Details class object as a field in Task class

Copy link
Copy Markdown
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kuruvasatya,
Thanks for this PR! I have not detailed enough the issue but details can contains differents fields in the case of indexCreation you will have:

    "type": "indexCreation",
        "details": {
            "primaryKey": null
        },

In case of indexDeletion:

    "type": "indexDeletion",
        "details": {
            "deletedDocuments": 30
        },

And others you can find the list of every request you will receive a task.
I think that's why the tests don't work.
Don't hesitate if you have more questions.

@kuruvasatya
Copy link
Copy Markdown
Contributor Author

Hi @alallema,
Thanks for reviewing my PR, I have another idea, we can use Map<String, String> details in Task class to add details field, whats your take on this?

Also i have issues with linting, i am not able to find what is the real issue is... If you dont mind Can you please help me with that?

@bidoubiwa
Copy link
Copy Markdown
Contributor

There some types missing: See example

@alallema
Copy link
Copy Markdown
Contributor

alallema commented Feb 8, 2022

@kuruvasatya, I see you open a new PR #336 did I close this one?

@alallema
Copy link
Copy Markdown
Contributor

alallema commented Feb 9, 2022

I closed this PR in favor of #336 336

@alallema alallema closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding details field to Task class

3 participants