Add details field to Task class#335
Add details field to Task class#335kuruvasatya wants to merge 1 commit intomeilisearch:mainfrom kuruvasatya:changeTaskClass
Conversation
There was a problem hiding this comment.
Hi @kuruvasatya,
Thanks for this PR! I have not detailed enough the issue but details can contains differents fields in the case of indexCreation you will have:
"type": "indexCreation",
"details": {
"primaryKey": null
},In case of indexDeletion:
"type": "indexDeletion",
"details": {
"deletedDocuments": 30
},And others you can find the list of every request you will receive a task.
I think that's why the tests don't work.
Don't hesitate if you have more questions.
|
Hi @alallema, Also i have issues with linting, i am not able to find what is the real issue is... If you dont mind Can you please help me with that? |
|
There some types missing: See example |
|
@kuruvasatya, I see you open a new PR #336 did I close this one? |
|
I closed this PR in favor of #336 336 |
Pull Request
What does this PR do?
Fixes #331
created new class Details with two fields, and added Details class object as a field in Task class