Create new Details class and add Details field in Task class#336
Create new Details class and add Details field in Task class#336bors[bot] merged 6 commits intomeilisearch:mainfrom
Conversation
alallema
left a comment
There was a problem hiding this comment.
Thanks, @kuruvasatya for this PR!
The code is great can you just add some tests to check if the details class works well?
In this file src/test/java/com/meilisearch/integration/TasksTest.java there are tests on the Task class you can just add for example in the testClientGetTask:
assertNotNull(task.getDetails());
assertNull(task.getDetails().getPrimaryKey());
|
Hey @alallema , can you tell what I am doing wrong |
Hi @kuruvasatya, You rest of your tests is enough! Good job 🔥 |
alallema
left a comment
There was a problem hiding this comment.
LGTM!
Thank for contributing to Meilisearch ❤️
|
bors merge |
|
Build succeeded: |
Pull Request
What does this PR do?
Fixes #331
Created new Details class and added the Details field to Task class
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to MeiliSearch!