refactor(ui): remove StatusSurface scrim behind status-colored chips

[jamesarich]

Why

The translucent dark scrim pill (StatusSurface, added in #5985) that backed status-colored chips reads as visual noise on node cards and message bubbles. This removes it entirely, letting SNR/RSSI, signal quality, the signed shield, key-status icons, and the online last-heard timestamp render directly on the surface underneath in their true token colors.

🧹 Cleanup

• Delete StatusSurface / StatusScrim and StatusSurfaceTest (the scrim-contrast AA test; ColorContrastTest for the tokens themselves is unaffected)
• NodeItem: signal pill becomes a plain full-width Row; StatusAwareLastHeard collapses to a single tint-switched LastHeardInfo; NodeSecurityIcons becomes a plain Row
• NodeItemCompact: unwrap the signal-quality chip
• MessageItem: unwrap the signed-verified shield and the SNR/RSSI pair
• Regenerate screenshot goldens (44 reference PNGs)

Testing Performed

• spotlessApply spotlessCheck detekt assembleDebug test allTests — all green (1,968 tests)
• :screenshot-tests:updateDebugScreenshotTest then validateDebugScreenshotTest -Pci=true — 273 screenshot tests pass

🤖 Generated with Claude Code

Summary by CodeRabbit

• Style

  • Updated node signal, status, and health indicators with a cleaner, scrim-free presentation.
  • Refined message metadata visuals, including verification, signal, and connection details.
  • Improved consistency and readability across node and message information displays.

• Refactor

  • Simplified status indicator presentation while preserving existing visibility and conditional behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 14bcdc86-ce91-49e4-8afa-49dfd7dc2ee0

📥 Commits

Reviewing files that changed from the base of the PR and between 4232764 and b64582c.

⛔ Files ignored due to path filters (44)

• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/MessagingScreenshotTestsKt/ScreenshotMessageItemMarkdown_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/MessagingScreenshotTestsKt/ScreenshotMessageItemMarkdown_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/MessagingScreenshotTestsKt/ScreenshotMessageItemSigned_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/MessagingScreenshotTestsKt/ScreenshotMessageItemSigned_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactActive_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactActive_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactAllFields_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactAllFields_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactMinimal_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactMinimal_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactOnlineRemote_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompactOnlineRemote_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompleteActive_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompleteActive_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompleteOnlineRemote_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemCompleteOnlineRemote_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemComplete_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemComplete_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemSigned_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/NodeScreenshotTestsKt/ScreenshotNodeItemSigned_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsCompactMinimal_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsCompactMinimal_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsCompact_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsCompact_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsComplete_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotNodeLayoutSettingsComplete_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactAllFields_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactAllFields_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactNameOnly_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactNameOnly_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactSignalOnly_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactSignalOnly_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactToggleMatrix_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompactToggleMatrix_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteDirectSignal_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteDirectSignal_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteFahrenheit_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteFahrenheit_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteImperial_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteImperial_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteToggleMatrix_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeCompleteToggleMatrix_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeComplete_Dark_d19fbf1f_0.png is excluded by !**/*.png, !**/*.png
• screenshot-tests/src/screenshotTestDebug/reference/org/meshtastic/screenshots/feature/SettingsScreenshotTestsKt/ScreenshotSampleNodeComplete_Light_b29dc7a7_0.png is excluded by !**/*.png, !**/*.png

📒 Files selected for processing (5)

• core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItem.kt
• core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItemCompact.kt
• core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/StatusSurface.kt
• core/ui/src/commonTest/kotlin/org/meshtastic/core/ui/component/StatusSurfaceTest.kt
• feature/messaging/src/commonMain/kotlin/org/meshtastic/feature/messaging/component/MessageItem.kt

💤 Files with no reviewable changes (2)

• core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/StatusSurface.kt
• core/ui/src/commonTest/kotlin/org/meshtastic/core/ui/component/StatusSurfaceTest.kt

---

📝 Walkthrough

Walkthrough

StatusSurface and its tests were removed. Node signal, quality, and last-heard components, along with message metadata indicators, now render directly without scrim-backed wrappers while preserving their existing conditions and content.

Changes

Core status rendering

Layer / File(s)	Summary
Core status presentation core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItem.kt, NodeItemCompact.kt, StatusSurface.kt, core/ui/src/commonTest/.../StatusSurfaceTest.kt	Node signal, quality, and last-heard content no longer uses StatusSurface; the composable, scrim constant, and associated tests were removed.

Messaging metadata rendering

Layer / File(s)	Summary
Message status indicators feature/messaging/src/commonMain/kotlin/org/meshtastic/feature/messaging/component/MessageItem.kt	Verified-broadcast, SNR, and RSSI indicators render directly, with unused imports removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: ui

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing the StatusSurface scrim behind status-colored chips.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}