Develop Warning Clean-up

[Xaositek]

Sometimes Claude finds fixes to current code

Strategy:

1. Created a build for Cardputer which generated multiple warnings
2. Exported log and iterated through Claude to see about fixing any quick wins
3. Built for TEcho, Wio Tracker L1, and T114 - provided these logs additionally to Claude to verify any more fixes to warnings
4. Reverified that logs are how much cleaner!

All logs used are attached:
build_cardputer_finalbuild.log
build_cardputer_initialbuild.txt
build_t114.log
build_techo.log
build_wiotrackerl1.log
build_wismeshtag.log

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Cleans up build warnings across several targets by updating BLE connection parameter APIs, tightening conditional compilation, and clarifying intentional control flow in switches.

Changes:

• Replaced deprecated/legacy NimBLE connection parameter updates with requestConnParams().
• Reduced compiler warnings via explicit [[fallthrough]] and (void) casts for conditionally-used variables.
• Simplified string emptiness checks to avoid “always true” conditions and related warnings.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/nimble/NimbleBluetooth.cpp	Updates BLE connection parameter calls to requestConnParams() to reduce warnings/deprecations.
src/modules/StatusLEDModule.cpp	Suppresses unused-variable warnings when ledState is only used under platform #ifdefs.
src/modules/KeyVerificationModule.cpp	Refactors banner callback definition to avoid preprocessor macro argument issues.
src/modules/CannedMessageModule.cpp	Moves EINK-only variables under #ifdef and changes node-name checks to reduce warnings.
src/mesh/aes-ccm.cpp	Adjusts volatile casts in constant-time compare to reduce cast-related warnings.
src/graphics/draw/UIRenderer.cpp	Replaces pointer-style checks with empty-string checks for short_name.
src/gps/GPS.cpp	Adds explicit [[fallthrough]] to silence implicit fallthrough warnings.
src/detect/ScanI2CTwoWire.cpp	Adds explicit [[fallthrough]] to silence implicit fallthrough warnings.

[github-actions]

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

[NomDeTom]

I admire the sentiment, but I suspect this is just going to lead to more arguments with clod rather than fewer with the compiler.