Add configurable event mode hop limit - #11275
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughEvent mode gains validated configurable hop limits, applies them to default configuration, routing responses, rebroadcasts, and opaque relays, and adds unit coverage for response and relay hop-field behavior. ChangesEvent-mode hop limits
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant NextHopRouter
participant capEventRelayHops
participant MockRadioInterface
NextHopRouter->>capEventRelayHops: cap relay hop fields
capEventRelayHops-->>NextHopRouter: return adjusted packet
NextHopRouter->>MockRadioInterface: send adjusted packet
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RCGV1
marked this pull request as ready for review
July 29, 2026 00:46
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (31)
Build artifacts expire on 2026-08-28. Updated for |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/mesh/Default.cpp`:
- Line 95: Update the limit comparison in the relevant Default hop-limit
calculation to use >= so configured == eventModeHopLimit returns the event cap,
including when configured is 0. Add a test that passes
Default::eventModeHopLimit with config.lora.hop_limit set to HOP_MAX and
verifies the capped result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f8c7b69-7eec-4f0c-87db-a1dd2b5f6c1f
📒 Files selected for processing (6)
src/mesh/Default.cppsrc/mesh/Default.hsrc/mesh/NextHopRouter.cppsrc/mesh/NodeDB.cpptest/test_default/test_main.cpptest/test_nexthop_routing/test_main.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
- src/mesh/NodeDB.cpp
Merged
via the queue into
meshtastic:develop
with commit Jul 29, 2026
0fef83d
100 of 102 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USERPREFS_EVENT_MODE_HOP_LIMITas the event profile's baked default hop count and firmware-generated/relay cap.0through7, preserve the existing default of3when omitted, and reject invalid values at compile time.Defaultowner plus one local relay helper; no separate event-mode abstraction is added.hop_startadjustments consistent and safe for legacy packets wherehop_start == 0.Why
Event mode previously hard-coded a default hop count of three in multiple routing paths. Event builds need to choose that baked default without patching firmware sources, while retaining the current behavior when the preference is not set.
Validation
trunk fmt— clean across all 8 changed files.~/.platformio/penv/bin/python -m platformio test -e native-macos— 792/792 tests passed across 39 suites.0,5, and7, covering firmware responses, decoded and opaque relays, legacyhop_start, and explicit client overrides.8and7.5failed compilation through the intendedstatic_assert.~/.platformio/penv/bin/pio run -e heltec-v3— succeeded withUSERPREFS_EVENT_MODE=1andUSERPREFS_EVENT_MODE_HOP_LIMIT=5.Attestations
Summary by CodeRabbit