Skip to content

Align python-meshtastic packaging with upstream#81

Merged
vidplace7 merged 1 commit into
mainfrom
upstream-python-meshtastic
Jul 1, 2026
Merged

Align python-meshtastic packaging with upstream#81
vidplace7 merged 1 commit into
mainfrom
upstream-python-meshtastic

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Minor changes to align with @GeorgeSapkin's submission upstream.

Summary by CodeRabbit

  • Chores
    • Updated package metadata for the Python Meshtastic package, including maintainer information, license classification, package title, and project link.
    • Expanded the package description to better explain what the package provides.
    • Added an extra source package build while keeping the existing build intact.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c564231a-3ba9-4f28-a904-a1272aec0cac

📥 Commits

Reviewing files that changed from the base of the PR and between 5530c65 and babb2f1.

📒 Files selected for processing (1)
  • python-meshtastic/Makefile
🚧 Files skipped from review as they are similar to previous changes (1)
  • python-meshtastic/Makefile

📝 Walkthrough

Walkthrough

This PR updates the python-meshtastic OpenWrt package Makefile: adds an SPDX header, expands PKG_MAINTAINER, tightens PKG_LICENSE to GPL-3.0-only, changes package TITLE and URL, reformats DEPENDS, expands the description, and adds a build invocation for python3-meshtastic-src.

Changes

Package Metadata Update

Layer / File(s) Summary
License and maintainer metadata
python-meshtastic/Makefile
SPDX header replaces the prior license comment, PKG_LICENSE becomes GPL-3.0-only, and PKG_MAINTAINER gains an additional maintainer.
Package definition and build targets
python-meshtastic/Makefile
TITLE and URL are updated, DEPENDS is reformatted, the description is expanded, and a new BuildPackage call for python3-meshtastic-src is added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • meshtastic/openwrt#76: Both PRs modify the DEPENDS formatting in the same Package/python3-meshtastic section of the Makefile.

Poem

A rabbit hopped through Makefile lines,
Tidy SPDX and metadata signs,
One more maintainer joins the crew,
A source package build, fresh and new,
Thump thump—polished bright! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the packaging alignment changes made to python-meshtastic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Minor changes to align with George Sapkin's submission upstream
@vidplace7
vidplace7 force-pushed the upstream-python-meshtastic branch from 5530c65 to babb2f1 Compare July 1, 2026 00:36
@vidplace7
vidplace7 merged commit 18b3b10 into main Jul 1, 2026
11 checks passed
@vidplace7
vidplace7 deleted the upstream-python-meshtastic branch July 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant