Attribute SupervisionEvent to actor mesh if we can #1939
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
pzhan9
force-pushed
the
export-D87449139
branch
from
30f0721 to
4f08175
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
pzhan9
force-pushed
the
export-D87449139
branch
from
4f08175 to
d92d1cd
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
…ch#1936) Summary: As title. Reviewed By: mariusae Differential Revision: D87366183
Summary: Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields. This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`. Reviewed By: shayne-fletcher Differential Revision: D87374168
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
pzhan9
force-pushed
the
export-D87449139
branch
from
d92d1cd to
cc1b973
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139
|
This pull request has been merged in fc3e30e. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Nov 20, 2025
Summary: Pull Request resolved: meta-pytorch#1939 This diff attributes supervision events fired from `send_state_change` to the corresponding actor mesh. Reviewed By: vidhyav Differential Revision: D87449139 fbshipit-source-id: 052e1fc38061a03a9984a8b559ebb36e2c053b9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff attributes supervision events fired from
send_state_changeto the corresponding actor mesh.Reviewed By: vidhyav
Differential Revision: D87449139