PR 911+910+904 hotfixes to mgage new_develop_candidate_01_01_2019#23
Merged
Conversation
Remove contents of webwork2/htdocs/tmp when restarting webwork inside docker
This is an extremely small change that fixes the file uploaded successfully message. To test upload a file using the file manager. After the patch the file name should be displayed correctly.
…essage File '' uploaded successfully
…cepting empty or all white-space password even if they happen to match the crypted password in the database. (In certain settings such as LTI authentication and LDAP authentication, and when wwassignment is being used, some users may have such a null password.) Since the function is called as a fallback by some of the other authentication modules which do not "trim" the possibleClearPassword being sent for testing (unlike what is done in get_credentials() in lib/WeBWorK/Authen.pm), we explicitly test for a non-space character and don't only reject the possibleClearPassword when it is an empty string. This is intended to address the issue reported in the forums http://webwork.maa.org/moodle/mod/forum/discuss.php?d=4529 .
as an undef value of $self->{password} is needed for the
authenticate() function to detect session-timeout.
2. Prevent the localized "inactivity timeout" error message from
being overridden by an "authentication failed" error message
when it should not be overriden.
Owner
|
Thanks Tani. This looks good. |
taniwallach
deleted the
tani_forbid_whitespace_and_empty_passwords_during_checkPassword
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the same hotfixes recently merged into master, but into your new_develop_candidate_01_01_2019