RTL display fixes and Hebrew translation fixes#27
Merged
mgage merged 2 commits intoMay 23, 2019
Merged
Conversation
like Hebrew or Arabic. The data from lib/WeBWorK/ContentGenerator/Instructor/ShowAnswers.pm (using table formatting) and lib/WeBWorK/ContentGenerator/Instructor/StudentProgress.pm which are preformatted using a <pre> tag are not displated properly when the overall HTML document in in RTL direction. Force this data to be displayed LTR using an HTML dir attribute. For StudentProgress data an enveloping SPAN tag was needed. no changes added to commit (use "git add" and/or "git commit -a") [tani@webwork webwork2]$ git commit lib/WeBWorK/ContentGenerator/Instructor/ShowAnswers.pm lib/WeBWorK/ContentGenerator/Instructor/StudentProgress.pm
Owner
|
Looks ok. Thanks Tani. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<pre>preformated blocks does not behave in RTL pages.<span>withdir="rtl"fixes the display of the score/attempts data per student.dir="rtl"which fixes the problem.