RTL fixes for View and Edit in FileManager.pm#28
Merged
mgage merged 1 commit intoMay 24, 2019
Conversation
textarea for "Edit" and in a (new) enveloping DIV around the <pre> for "View". Then in courses whose primarly language used the RTL text direction, lines which start in LTL languages (most of the lines in PG files, the set definition files, etc) will be left justified and formatted nicely. Without this, all lines would be right justified based on the main dir="rtl" which applies to the entire HTML page.
Owner
|
Thanks Tani. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
FileManager.pmset the HTMLdir(ection) attribute to "auto" in the<textarea>for "Edit" and in a (new) enveloping DIV around the<pre>for "View".Then in courses whose primary language use the RTL text direction, lines which start in LTR languages (most of the lines in PG files, the set definition files, etc) will be left justified and formatted nicely.
Without this, all lines would be right justified based on the main
dir="rtl"which applies to the entire HTML page for courses whose languages use the RTL direction.