Dashing migration#11
Merged
BorjaOuterelo merged 21 commits intodashingfrom Jan 28, 2020
Merged
Conversation
added 10 commits
July 26, 2019 10:31
julionce
requested review from
BorjaOuterelo,
iluetkeb,
ralph-lange and
tkolcon
ralph-lange
reviewed
Aug 6, 2019
| <version>0.0.1</version> | ||
| <description>Example of a publisher using int32</description> | ||
| <maintainer email="julianbermudez@eprosima.com">Julian Bermudez</maintainer> | ||
| <license>Apache License 2.0</license> |
Contributor
There was a problem hiding this comment.
Suggested change
| <license>Apache License 2.0</license> | |
| <license>Apache-2.0</license> |
Cf. previous comment and https://spdx.org/licenses/
Author
There was a problem hiding this comment.
Thanks for the information. Change!
ralph-lange
reviewed
Aug 6, 2019
| } | ||
| } while (rv); | ||
|
|
||
| rv = rcl_subscription_fini(&subscription, &node); |
Contributor
There was a problem hiding this comment.
Suggested change
| rv = rcl_subscription_fini(&subscription, &node); | |
| rcl_subscription_fini(&subscription, &node); |
rv is not used.
Author
There was a problem hiding this comment.
It is outdated, new we use macros for return-value-checking.
ralph-lange
reviewed
Aug 6, 2019
| } while (rv); | ||
|
|
||
| rv = rcl_subscription_fini(&subscription, &node); | ||
| rv = rcl_node_fini(&node); |
Contributor
There was a problem hiding this comment.
Suggested change
| rv = rcl_node_fini(&node); | |
| rcl_node_fini(&node); |
rv is not used.
Author
There was a problem hiding this comment.
It is outdated, new we use macros for return-value-checking.
ralph-lange
reviewed
Aug 6, 2019
| rclcpp::QoS qos(10); | ||
| publisher_ = this->create_publisher<complex_msgs::msg::NestedMsgTest>( | ||
| "complex_msgs_msg_NestedMsgTest"); | ||
| "complex_msgs_msg_NestedMsgTest", qos); |
Contributor
There was a problem hiding this comment.
You may want to use rclcpp::SystemDefaultsQoS() instead.
ralph-lange
reviewed
Aug 6, 2019
| rclcpp::QoS qos(10); | ||
| subscription_ = this->create_subscription<complex_msgs::msg::NestedMsgTest>( | ||
| "complex_msgs_msg_NestedMsgTest", | ||
| "complex_msgs_msg_NestedMsgTest", qos, |
Contributor
There was a problem hiding this comment.
Possible to use rclcpp::SystemDefaultsQoS() instead?
ralph-lange
reviewed
Aug 6, 2019
Contributor
ralph-lange
left a comment
ralph-lange
left a comment
There was a problem hiding this comment.
Looks good to me. I like the proper renaming of the packages with suffixes _rclcpp or _rclc. In the next months, we should get rid of rclc completely.
* Add services examples * Refactor pub/sub examples * Add action server example * Action server updated * Add action client example * Adjust action client and server demos * Indentation fix * Ensure finalizing elements * Name typo * Ensure fini elements * Using RCL_MS_TO_NS function in rcl_wait * Style consistency * Independent action client event checking * Style fix * Error handling * Typo * Added multinode example Check required * Sleep to wait matching comment * Indentation fix * Return codes removed
* Refactor add two ints requester * Style refactor and macro rc check * Typos * Typos * rc variable independace * Typo
* Add configuration examples. * Added configuration examples * Client key API * Fix * Examples cleanup ad error code check * Added error check macros * Indentation fix * Indentation fix * Indentation fix Co-authored-by: Borja Outerelo <borjaouterelo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adapts these demos to Dashing release.
These demos has been reorganized in different folder
c -> rclcandcpp -> rclcpp.rclporting has not been done yet.