Fix some warnings#16
Merged
BorjaOuterelo merged 1 commit intofeature/dashing_migrationfrom Jan 24, 2020
Merged
Conversation
pablogs9
approved these changes
Jan 17, 2020
BorjaOuterelo
added a commit
that referenced
this pull request
Jan 28, 2020
* Refs #6007. Move example to rclc and rclcpp folders. * Refs #6607. Add .gitignore. * Refs #6007. Add rcl int32_publisher example. * Refs #6007. Add rcl int32_subscriber example. * Refs #6130. Modify rcl int32_publisher and int32_subscriber examples. * Refs #6130. Check Clang-Tidy installation for examples. * Refs #6130. Rename rclc examples. * Refs #6130. Rename rclcpp examples. * Refs #6130. Fix packages.xml. * Refs #6130. Fix rclcpp examples warnings. * Group demos executables in packages. * Fix rcl demo implementation. * Add rcl error print and fix subscription. * Feature/actions (#14) * Add services examples * Refactor pub/sub examples * Add action server example * Action server updated * Add action client example * Adjust action client and server demos * Indentation fix * Ensure finalizing elements * Name typo * Ensure fini elements * Using RCL_MS_TO_NS function in rcl_wait * Style consistency * Independent action client event checking * Style fix * Error handling * Typo * Added multinode example Check required * Sleep to wait matching comment * Indentation fix * Return codes removed * Feature/demos cleanup (#15) * Refactor add two ints requester * Style refactor and macro rc check * Typos * Typos * rc variable independace * Typo * Feature/configuration (#13) * Add configuration examples. * Added configuration examples * Client key API * Fix * Examples cleanup ad error code check * Added error check macros * Indentation fix * Indentation fix * Indentation fix Co-authored-by: Borja Outerelo <borjaouterelo@gmail.com> * Fix some warnings. (#16) * Guard condition example (#17) * Cleaning subscriptor code (#18) * Change Apache license identifier in package.xml files. * Apply suggestions from code review. Co-authored-by: Borja Outerelo <borjaouterelo@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes some warnings at
addtwoints_clientandfibonacci_action_client.