Skip to content

Feature/configuration#13

Merged
julionce merged 9 commits intofeature/dashing_migrationfrom
feature/configuration
Jan 20, 2020
Merged

Feature/configuration#13
julionce merged 9 commits intofeature/dashing_migrationfrom
feature/configuration

Conversation

@pablogs9
Copy link
Copy Markdown
Member

@pablogs9 pablogs9 commented Jan 7, 2020

This PR adds RMW configuration examples and updates the examples that uses the default configuration (set at building time).

Comment thread rcl/configuration_example/configured_publisher/main.c Outdated
Comment thread rcl/configuration_example/configured_publisher/CMakeLists.txt
Comment thread rcl/configuration_example/configured_subscriber/CMakeLists.txt Outdated
Comment thread rcl/configuration_example/configured_subscriber/main.c Outdated
@julionce julionce assigned pablogs9 and unassigned julionce Jan 15, 2020
@pablogs9 pablogs9 assigned julionce and unassigned pablogs9 Jan 16, 2020
@julionce julionce self-requested a review January 17, 2020 06:34
Copy link
Copy Markdown

@julionce julionce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve conflicts.

@julionce julionce assigned pablogs9 and unassigned julionce Jan 17, 2020
@pablogs9 pablogs9 force-pushed the feature/configuration branch from a5ed267 to 8cb6f85 Compare January 17, 2020 08:00
@pablogs9
Copy link
Copy Markdown
Member Author

Conflicts resolved

@pablogs9 pablogs9 assigned julionce and unassigned pablogs9 Jan 17, 2020
@julionce julionce merged commit 13c3caa into feature/dashing_migration Jan 20, 2020
BorjaOuterelo added a commit that referenced this pull request Jan 28, 2020
* Refs #6007. Move example to rclc and rclcpp folders.

* Refs #6607. Add .gitignore.

* Refs #6007. Add rcl int32_publisher example.

* Refs #6007. Add rcl int32_subscriber example.

* Refs #6130. Modify rcl int32_publisher and int32_subscriber examples.

* Refs #6130. Check Clang-Tidy installation for examples.

* Refs #6130. Rename rclc examples.

* Refs #6130. Rename rclcpp examples.

* Refs #6130. Fix packages.xml.

* Refs #6130. Fix rclcpp examples warnings.

* Group demos executables in packages.

* Fix rcl demo implementation.

* Add rcl error print and fix subscription.

* Feature/actions (#14)

* Add services examples

* Refactor pub/sub examples

* Add action server example

* Action server updated

* Add action client example

* Adjust action client and server demos

* Indentation fix

* Ensure finalizing elements

* Name typo

* Ensure fini elements

* Using RCL_MS_TO_NS function in rcl_wait

* Style consistency

* Independent action client event checking

* Style fix

* Error handling

* Typo

* Added multinode example

Check required

* Sleep to wait matching comment

* Indentation fix

*  Return codes removed

* Feature/demos cleanup (#15)

* Refactor add two ints requester

* Style refactor and macro rc check

* Typos

* Typos

* rc variable independace

* Typo

* Feature/configuration (#13)

* Add configuration examples.

* Added configuration examples

* Client key API

* Fix

* Examples cleanup ad error code check

* Added error check macros

* Indentation fix

* Indentation fix

* Indentation fix

Co-authored-by: Borja Outerelo <borjaouterelo@gmail.com>

* Fix some warnings. (#16)

* Guard condition example (#17)

* Cleaning subscriptor code (#18)

* Change Apache license identifier in package.xml files.

* Apply suggestions from code review.

Co-authored-by: Borja Outerelo <borjaouterelo@gmail.com>
Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
@pablogs9 pablogs9 deleted the feature/configuration branch May 28, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants