RMW QoS incoming buffer handling by pablogs9 · Pull Request #165 · micro-ROS/rmw_microxrcedds

pablogs9 · 2021-09-08T13:02:31Z

This PR implements the logic for handling the incoming RMW buffer depending on the QoS

TODO:

Req res tests
Backport to main and foxy

This reverts commit 9f46d80.

This reverts commit cb7a130.

github-actions · 2021-09-10T08:18:42Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

pablogs9 · 2021-09-10T09:56:17Z

@mergify backport main foxy

mergify · 2021-09-10T09:56:54Z

Command backport main foxy: pending

Waiting for the pull request to get merged

Hey, I reacted but my real name is @Mergifyio

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>

github-actions · 2021-09-28T09:50:23Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

github-actions · 2021-09-28T09:50:37Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

codecov-commenter · 2021-09-28T09:51:16Z

Codecov Report

❗ No coverage uploaded for pull request base (galactic@b996df1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b9a703f differs from pull request most recent head 4c342c2. Consider uploading reports for the commit 4c342c2 to get more accurate results

@@             Coverage Diff             @@
##             galactic     #165   +/-   ##
===========================================
  Coverage            ?   49.75%           
===========================================
  Files               ?       42           
  Lines               ?     1618           
  Branches            ?      319           
===========================================
  Hits                ?      805           
  Misses              ?      614           
  Partials            ?      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b996df1...4c342c2. Read the comment docs.

github-actions · 2021-09-28T09:55:45Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

github-actions · 2021-09-28T10:28:12Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

github-actions · 2021-09-28T10:49:37Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

github-actions · 2021-09-28T12:42:25Z

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity	Qty	Size per unit
Context	2	5600 B
Topic	8	56 B
Service	4	168 B
Client	4	168 B
Subscription	4	168 B
Publisher	4	184 B
Node	4	56 B
Static input buffer	8	2136 B

TOTAL: 31492 B

* Initial * Update * Uncrustify * Fixes * Tests pubsub * Add two subs test * Uncrustify * Initial reqres * Adding complete req res tests * Uncrustify * Use absolute time reference * Avoid future data * Speedup tests * Update * Update * Pub/sub in best effort * Fix * Revert "Pub/sub in best effort" This reverts commit 9f46d80. * Revert "Fix" This reverts commit cb7a130. * Major review of rmw_wait * Uncrustify * Adapt Cmake * client branch * Update * Update * Uncrustify * Update rmw_microxrcedds_c/CMakeLists.txt Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update rmw_microxrcedds_c/src/config.h.in Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Fix on_topic callback * Fix timeout handling * Exit if deserialize fails * Update .github/workflows/ci.yml Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio cuadros <acuadros1995@gmail.com> (cherry picked from commit b1531c7) # Conflicts: # rmw_microxrcedds_c/src/types.h

* Initial * Update * Uncrustify * Fixes * Tests pubsub * Add two subs test * Uncrustify * Initial reqres * Adding complete req res tests * Uncrustify * Use absolute time reference * Avoid future data * Speedup tests * Update * Update * Pub/sub in best effort * Fix * Revert "Pub/sub in best effort" This reverts commit 9f46d80. * Revert "Fix" This reverts commit cb7a130. * Major review of rmw_wait * Uncrustify * Adapt Cmake * client branch * Update * Update * Uncrustify * Update rmw_microxrcedds_c/CMakeLists.txt Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update rmw_microxrcedds_c/src/config.h.in Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Fix on_topic callback * Fix timeout handling * Exit if deserialize fails * Update .github/workflows/ci.yml Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio cuadros <acuadros1995@gmail.com> (cherry picked from commit b1531c7) # Conflicts: # rmw_microxrcedds_c/test/test_pubsub.cpp # rmw_microxrcedds_c/test/test_reqres.cpp

mergify · 2021-09-28T12:58:23Z

Command backport main foxy: success

Backports have been created

#176 RMW QoS incoming buffer handling (backport #165) has been created for branch main

#177 RMW QoS incoming buffer handling (backport #165) has been created for branch foxy

* RMW QoS incoming buffer handling (#165) * Initial * Update * Uncrustify * Fixes * Tests pubsub * Add two subs test * Uncrustify * Initial reqres * Adding complete req res tests * Uncrustify * Use absolute time reference * Avoid future data * Speedup tests * Update * Update * Pub/sub in best effort * Fix * Revert "Pub/sub in best effort" This reverts commit 9f46d80. * Revert "Fix" This reverts commit cb7a130. * Major review of rmw_wait * Uncrustify * Adapt Cmake * client branch * Update * Update * Uncrustify * Update rmw_microxrcedds_c/CMakeLists.txt Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update rmw_microxrcedds_c/src/config.h.in Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Fix on_topic callback * Fix timeout handling * Exit if deserialize fails * Update .github/workflows/ci.yml Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio cuadros <acuadros1995@gmail.com> (cherry picked from commit b1531c7) # Conflicts: # rmw_microxrcedds_c/src/types.h * Fix conflict * Update Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

* RMW QoS incoming buffer handling (#165) * Initial * Update * Uncrustify * Fixes * Tests pubsub * Add two subs test * Uncrustify * Initial reqres * Adding complete req res tests * Uncrustify * Use absolute time reference * Avoid future data * Speedup tests * Update * Update * Pub/sub in best effort * Fix * Revert "Pub/sub in best effort" This reverts commit 9f46d80. * Revert "Fix" This reverts commit cb7a130. * Major review of rmw_wait * Uncrustify * Adapt Cmake * client branch * Update * Update * Uncrustify * Update rmw_microxrcedds_c/CMakeLists.txt Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update rmw_microxrcedds_c/src/config.h.in Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Fix on_topic callback * Fix timeout handling * Exit if deserialize fails * Update .github/workflows/ci.yml Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio cuadros <acuadros1995@gmail.com> (cherry picked from commit b1531c7) # Conflicts: # rmw_microxrcedds_c/test/test_pubsub.cpp # rmw_microxrcedds_c/test/test_reqres.cpp * resolve conflicts * Fix * fix * Update timeout * Fix time * Fix * Fix tests * Fix time unit Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Antonio cuadros <acuadros1995@gmail.com>

pablogs9 added 6 commits September 7, 2021 16:31

Initial

bcb1e40

Update

01670bb

Uncrustify

cd71ef2

Fixes

d2713d1

Tests pubsub

e03ceb5

Add two subs test

6fb8b4b

pablogs9 requested a review from Acuadros95 September 8, 2021 13:02

pablogs9 added 16 commits September 8, 2021 15:04

Uncrustify

4927a03

Initial reqres

e79f351

Adding complete req res tests

7a24463

Uncrustify

ae51732

Use absolute time reference

758c00d

Avoid future data

3c241f7

Speedup tests

b6177ea

Update

d18bbd7

Update

83a0c45

Pub/sub in best effort

9f46d80

Fix

cb7a130

Revert "Pub/sub in best effort"

49643f0

This reverts commit 9f46d80.

Revert "Fix"

41b40e2

This reverts commit cb7a130.

Major review of rmw_wait

53b20fa

Uncrustify

0ea9772

Adapt Cmake

fd2558d

pablogs9 mentioned this pull request Sep 9, 2021

Add binary history depth eProsima/Micro-XRCE-DDS-Client#266

Merged

client branch

0fd960d

pablogs9 commented Sep 9, 2021

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

pablogs9 added 3 commits September 9, 2021 15:43

Update

202ab7d

Update

c0e10cf

Uncrustify

7c30f5d

Acuadros95 reviewed Sep 28, 2021

View reviewed changes

Comment thread rmw_microxrcedds_c/CMakeLists.txt Outdated

Comment thread rmw_microxrcedds_c/src/config.h.in Outdated

Comment thread rmw_microxrcedds_c/src/rmw_wait.c Outdated

Comment thread rmw_microxrcedds_c/src/types.c

Comment thread rmw_microxrcedds_c/src/callbacks.c

Acuadros95 reviewed Sep 28, 2021

View reviewed changes

Comment thread rmw_microxrcedds_c/test/test_reqres.cpp

pablogs9 and others added 2 commits September 28, 2021 11:48

Update rmw_microxrcedds_c/CMakeLists.txt

eeebe29

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>

Update rmw_microxrcedds_c/src/config.h.in

0924fe9

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>

Fix on_topic callback

767b0fc

Fix timeout handling

c94e6e7

pablogs9 requested a review from Acuadros95 September 28, 2021 10:27

Exit if deserialize fails

8c914f0

Acuadros95 approved these changes Sep 28, 2021

View reviewed changes

Update .github/workflows/ci.yml

4c342c2

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

Acuadros95 approved these changes Sep 28, 2021

View reviewed changes

pablogs9 merged commit b1531c7 into galactic Sep 28, 2021

pablogs9 deleted the feature/qos_buffers branch September 28, 2021 12:57

mergify Bot mentioned this pull request Sep 28, 2021

RMW QoS incoming buffer handling (backport #165) #176

Merged

mergify Bot mentioned this pull request Sep 28, 2021

RMW QoS incoming buffer handling (backport #165) #177

Merged

Uh oh!

Conversation

pablogs9 commented Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 10, 2021

Static memory analysis

Uh oh!

pablogs9 commented Sep 10, 2021

Uh oh!

mergify Bot commented Sep 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

codecov-commenter commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

github-actions Bot commented Sep 28, 2021

Static memory analysis

Uh oh!

mergify Bot commented Sep 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pablogs9 commented Sep 8, 2021 •

edited

Loading

codecov-commenter commented Sep 28, 2021 •

edited

Loading