Skip to content

Static operation - #184

Merged
pablogs9 merged 10 commits into
galacticfrom
fix/static_operation
Nov 4, 2021
Merged

Static operation#184
pablogs9 merged 10 commits into
galacticfrom
fix/static_operation

Conversation

@pablogs9

@pablogs9 pablogs9 commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@pablogs9
pablogs9 requested a review from Acuadros95 October 27, 2021 11:08
@pablogs9

pablogs9 commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

@mergify backport main foxy

@mergify

mergify Bot commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

backport main foxy

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@github-actions

github-actions Bot commented Oct 28, 2021

Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5608 B
Topic 8 56 B
Service 4 288 B
Client 4 288 B
Subscription 4 312 B
Publisher 4 328 B
Node 4 344 B
Static input buffer 8 2136 B

TOTAL: 34772 B

@github-actions

github-actions Bot commented Oct 28, 2021

Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5608 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 2 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34196 B

Acuadros95
Acuadros95 reviewed Nov 2, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_guard_condition.c
Acuadros95
Acuadros95 reviewed Nov 2, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_init.c
@github-actions

github-actions Bot commented Nov 2, 2021

Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5608 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 3 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34134 B

@pablogs9
pablogs9 merged commit cb4f522 into galactic Nov 4, 2021
@pablogs9
pablogs9 deleted the fix/static_operation branch November 4, 2021 07:21
mergify Bot pushed a commit that referenced this pull request Nov 4, 2021
@pablogs9 mergify-bot
Static operation (#184)
20fbadf 
* Static RMW operation

* Uncrustify

* Remove rmw_handle

* Update tests

* Update size calculator

* Update

* Add guard_condition init

* Add define for rmw_options size

* Update custom_guard_condition init

* Fix func name

Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com>
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit cb4f522)

# Conflicts:
#	rmw_microxrcedds_c/src/rmw_microros_internal/types.h
@mergify mergify Bot mentioned this pull request Nov 4, 2021
Merged
@pablogs9

pablogs9 commented Nov 4, 2021

Copy link
Copy Markdown
Member Author

@mergify backport main foxy

mergify Bot pushed a commit that referenced this pull request Nov 4, 2021
@pablogs9 mergify-bot
Static operation (#184)
6256770 
* Static RMW operation

* Uncrustify

* Remove rmw_handle

* Update tests

* Update size calculator

* Update

* Add guard_condition init

* Add define for rmw_options size

* Update custom_guard_condition init

* Fix func name

Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com>
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit cb4f522)

# Conflicts:
#	README.md
#	rmw_microxrcedds_c/CMakeLists.txt
@mergify mergify Bot mentioned this pull request Nov 4, 2021
Merged
@mergify

mergify Bot commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

backport main foxy

✅ Backports have been created

Details

@mergify

mergify Bot commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

backport main foxy

✅ Backports have been created

Details

Hey, I reacted but my real name is @Mergifyio

pablogs9 added a commit that referenced this pull request Nov 4, 2021
@mergify @pablogs9
Static operation (backport #184) (#190)
233e683 
* Static operation (#184)

* Static RMW operation

* Uncrustify

* Remove rmw_handle

* Update tests

* Update size calculator

* Update

* Add guard_condition init

* Add define for rmw_options size

* Update custom_guard_condition init

* Fix func name

Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com>
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit cb4f522)

# Conflicts:
#	README.md
#	rmw_microxrcedds_c/CMakeLists.txt

* Fix conflicts

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9 added a commit that referenced this pull request Nov 4, 2021
@mergify @pablogs9
Static operation (backport #184) (#189)
fb6a063 
* Static operation (#184)

* Static RMW operation

* Uncrustify

* Remove rmw_handle

* Update tests

* Update size calculator

* Update

* Add guard_condition init

* Add define for rmw_options size

* Update custom_guard_condition init

* Fix func name

Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com>
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit cb4f522)

# Conflicts:
#	rmw_microxrcedds_c/src/rmw_microros_internal/types.h

* Solve conflicts

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Acuadros95 Acuadros95 Acuadros95 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogs9 @Acuadros95