Fido: Add extra to pre-select transport and disable instant#3463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications relying on
fido-core(like Passchain) may need some control on instant-level and transport selection.This is particularly useful when implementing CredentialProviderService, as it allows to offer entries to use USB, NFC or hybrid directly in the OS-dialog to pick a credential, as we can do with the
preselectedCredentialId.The option to disable Instant and Pre-Selection is also a must in this case, as we can give an action to go to the transport selection: during the OS dialog to select the credential, the user can click on Sign-in options > Our options and get the transport selection view
I think these option could be used with microg's RemoteService, as I did with Passchain. It gives a good UX