fix(python): validate dimensions in list_to_2d_float_array#9799
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Reject negative sizes and length mismatches with an explicit ValueError instead of an opaque numpy reshape failure. Soft-empty 0x0 buffers stay supported. Offline unit tests included (no simulator). Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
list_to_2d_float_arraynow rejects negative sizes and length mismatches with an explicitValueErrorinstead of leaking numpy reshape noise. Empty0×0buffers remain valid.Why
Depth helpers sometimes feed truncated flat buffers after empty image responses; clearer fail-closed errors help API callers.
Test plan
python3 PythonClient/airsim/tests/test_utils_reshape.py -v(4 tests)Does not touch
string_to_*/write_file(see open #9795 / #9796).