Fixes for task_bench - #7359
Merged
Amaury Chamayou (achamayou) merged 5 commits intoOct 16, 2025
Merged
Conversation
Max (maxtropets)
approved these changes
Oct 15, 2025
Amaury Chamayou (achamayou)
approved these changes
Oct 15, 2025
Amaury Chamayou (achamayou)
enabled auto-merge
October 15, 2025 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #7357 (and #7329).
ASAN caught trivial stack corruption from the dequeue contention tests, because we flushed a single task rather than all (re-using a global object, not asserting anything interesting at the end of a benchmark test). This stack corruption resulted in other tests attempting to create too many threads, and a system error.
Relatedly, I was seeing rare but confounding instances of the merge sort benchmark failing because the resulting data wasn't sorted, but only in Debug and ASAN. This was because of a hard timeout in the flushing util function they used - finishing after 5s rather than when the task was truly complete. Unused timeout removed, tests now pass under ASAN.