Derive endorsed_tcb dynamically from attestation report in SNP test#7699
Merged
achamayou merged 2 commits intotest_endorsed_tcbfrom Mar 4, 2026
Merged
Derive endorsed_tcb dynamically from attestation report in SNP test#7699achamayou merged 2 commits intotest_endorsed_tcbfrom
achamayou merged 2 commits intotest_endorsed_tcbfrom
Conversation
Merged
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on verifySnpAttestation logic for endorsed TCB handling
Derive endorsed_tcb dynamically from attestation report in SNP test
Mar 4, 2026
achamayou
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
endorsed_tcbparameter in the SNP attestation test was hardcoded ("541700000000000a"), making it brittle across SNP hosts and processor architectures (Milan/Genoa/Turin) where the reported TCB varies.Changes
tests/npm_tests.py: Replace the hardcodedendorsed_tcbvalue with one derived fromreported_tcbin the firstverifySnpAttestationresponse. The first call (already present in the test) returns the attestation report containingreported_tcb— a hex string encoding the actual TCB for the running architecture. That value is then passed asendorsed_tcbin the second call.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.