Conversation
|
@copilot also run the programmability test on Genoa and Milan, that's what exercises the verifySnpAttestation JS API |
|
@achamayou I've opened a new pull request, #7669, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds coverage for endorsed_tcb handling in the npm/TypeScript verifySnpAttestation endpoint to prevent regressions from the earlier endorsed TCB endianness change, and ensures the relevant e2e test runs in SNP CI.
Changes:
- Extend
tests/npm_tests.pyto call/app/verifySnpAttestationwith anendorsed_tcbparameter. - Label the
programmability_and_jwte2e test assnpso it is executed in the SNP-labelled CI jobs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/npm_tests.py | Adds a new SNP-only request variant that supplies endorsed_tcb when verifying a node’s attestation. |
| CMakeLists.txt | Marks programmability_and_jwt with the snp CTest label so it runs under ./tests.sh ... -L snp. |
|
@achamayou I've opened a new pull request, #7699, to work on those changes. Once the pull request is ready, I'll request review from you. |
…7699) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
|
@copilot ok this is good, keep everything you've added, but add one more check afterwards, where you call verifySnpAttestation with an endorsed_tcb that's the correct size but contains only zeroes, and check that this is rejected as expected. |
|
@achamayou I've opened a new pull request, #7704, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Closes #7625