Test endorsed TCB in verifySnpAttestation#7704
Merged
achamayou merged 3 commits intotest_endorsed_tcbfrom Mar 5, 2026
Merged
Conversation
Merged
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with endorsed TCB testing
Test endorsed TCB in verifySnpAttestation
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e test coverage for the
endorsed_tcbparameter in theverifySnpAttestationJS API to prevent regressions from the endianness fix.verifySnpAttestationwithoutendorsed_tcbretrieves the attestation report;reported_tcbfrom that response is used asendorsed_tcbin subsequent calls, making the test work across Milan/Genoa/Turinendorsed_tcbasserts successendorsed_tcbof correct size asserts 400 rejectionprogrammability_and_jwttest marked withsnplabel so it runs in SNP CI jobs💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.