Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/76abbdc5-6003-4f3f-9423-6a5feff51213 Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/76abbdc5-6003-4f3f-9423-6a5feff51213 Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
achamayou
April 15, 2026 08:33
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the /node/memory endpoint and its supporting types/serialization, cleaning up OpenAPI, tests, and documentation now that SGX-specific memory monitoring is no longer relevant.
Changes:
- Deleted
/node/memoryhandler,MemoryUsagetypes, and related JSON/OpenAPI schema. - Removed e2e/perf test usage and reporting of
/node/memory-derived metrics. - Cleaned up PAL memory helper (
get_mallinfo) and updated docs/changelog accordingly.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/infra/runner.py | Removes post-run /node/memory metric collection and related import. |
| tests/infra/piccolo_driver.py | Removes /node/memory metric collection and related import. |
| tests/infra/basicperf.py | Removes /node/memory metric collection during perf runs. |
| tests/historical_query_perf.py | Removes stray /node/memory call. |
| tests/e2e_suite.py | Drops mem_stats() helper and removes memory field from test reporting. |
| tests/e2e_common_endpoints.py | Removes test_memory() and its invocation. |
| src/node/rpc/serialization.h | Removes JSON serialization declarations for MemoryUsage::Out. |
| src/node/rpc/node_frontend.h | Removes /memory endpoint registration and PAL include. |
| src/node/rpc/node_call_types.h | Removes MemoryUsage call type and PAL include. |
| include/ccf/pal/mem.h | Removes MallocInfo and get_mallinfo() implementation (keeps safe_memcpy). |
| doc/schemas/node_openapi.json | Removes /node/memory path and MemoryUsage__Out schema component. |
| doc/build_apps/release_policy.rst | Removes “memory usage” reference from operator API description. |
| CHANGELOG.md | Adds changelog entry noting removal of /node/memory. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
achamayou
approved these changes
Apr 15, 2026
eddyashton
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/node/memoryendpoint exposed heap size metrics that were primarily useful for monitoring SGX enclave memory budgets. With SGX support removed, this endpoint serves no meaningful purpose — the same information is available via standard OS tooling (/proc,getrusage, etc.).Core removal
src/node/rpc/node_frontend.h: Remove endpoint handler andccf/pal/mem.hincludesrc/node/rpc/node_call_types.h: RemoveMemoryUsagestructsrc/node/rpc/serialization.h: Remove JSON serialization macros forMemoryUsage::Outinclude/ccf/pal/mem.h: RemoveMallocInfostruct andget_mallinfo()(retainsafe_memcpy, still used byring_buffer.h)OpenAPI schema
doc/schemas/node_openapi.json: Remove/node/memorypath andMemoryUsage__OutcomponentTests
tests/e2e_common_endpoints.py: Removetest_memory()and its invocationtests/e2e_suite.py: Removemem_stats()helper and its usage in test reportingtests/infra/runner.py,basicperf.py,piccolo_driver.py: Remove post-run memory metric collection via/node/memorytests/historical_query_perf.py: Remove strayc.get("/node/memory")callimport httpinrunner.pyandpiccolo_driver.pyDocumentation
doc/build_apps/release_policy.rst: Remove "memory usage" from operator API descriptionCHANGELOG.md: Added removal entry under[7.0.0-rc2] → Removed