Get benchmark node memory stats from /proc#7856
Merged
achamayou merged 5 commits intomicrosoft:mainfrom May 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the removed /node/memory endpoint by collecting node memory metrics directly from /proc/<pid>/status during e2e benchmark runs (and including per-test memory snapshots in the e2e suite report), so these values can continue to be published to Bencher on supported platforms.
Changes:
- Add
/proc/<pid>/statusparsing helper to extract RSS/peak RSS/virtual size in bytes. - Publish primary-node memory metrics to Bencher in benchmark runners.
- Record per-node memory stats in
e2e_suite.pytest run reporting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/infra/proc.py | Adds get_proc_memory_stats() to read RSS/HWM/VmSize from /proc. |
| tests/infra/runner.py | Collects primary PID memory stats and publishes them to Bencher after benchmark runs. |
| tests/infra/piccolo_driver.py | Collects primary PID memory stats and publishes them to Bencher after benchmark runs. |
| tests/infra/basicperf.py | Collects primary PID memory stats and publishes them to Bencher (when primary wasn’t stopped). |
| tests/e2e_suite.py | Adds mem_stats() and includes memory info in per-test JSON reporting. |
cjen1-msft
approved these changes
Apr 30, 2026
cjen1-msft
pushed a commit
to cjen1-msft/CCF
that referenced
this pull request
May 6, 2026
Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7822. We no longer need a built-in
/node/memoryendpoint, since these stats can be gathered for current platforms from standard tools. This uses those standard tools (reading from/proc/{pid}/status) to get memory use during our e2e benchmark runs, restoring those values going to Bencher.