Remove internal CommittableTx changelog entry - #8270
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
September 3, 2026 09:33
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward removal of an internal-API changelog entry and does not affect code behavior.
Pull request overview
This PR updates CCF’s release notes to avoid documenting an internal API change (ccf::kv::CommittableTx) as a user-facing changelog item, while keeping the user-visible “stale-view write” fix entry.
Changes:
- Removed the changelog bullet describing the internal
CommittableTx::commit()signature change. - Retained the changelog note describing the stale-view write rejection fix (
#8242).
Custom instructions used:
.github/copilot-instructions.md.github/instructions/changelog.instructions.md.github/instructions/reviewing.instructions.md
File summaries
| File | Description |
|---|---|
CHANGELOG.md |
Removes a user-facing entry for an internal API change while preserving the stale-view write fix note. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eddy Ashton (eddyashton)
approved these changes
Sep 3, 2026
Amaury Chamayou (achamayou)
enabled auto-merge (squash)
September 3, 2026 10:50
Max (maxtropets)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommittableTxis internal rather than part of CCF's public API, so its signature change should not be documented as a user-facing change. Remove that entry while retaining the changelog note for the stale-view write fix.Follow-up to #8242 and review discussion.