Enforce dependencies for acyclic source components - #8278
Merged
Conversation
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
September 4, 2026 10:19
View session
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Extends the source dependency checker’s explicit allowlist to cover all currently acyclic source components, preventing unnoticed new outgoing dependencies outside the cyclic core.
Changes:
- Added allowlist entries for additional acyclic components (
apps,cose,msgpack,tasks,tcp,threading,tls,udp) - Expanded
appsallowlist to include syntheticccf-api(andjs)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
Amaury Chamayou (achamayou) due to an error
September 4, 2026 10:39
This was referenced Sep 4, 2026
Eddy Ashton (eddyashton)
approved these changes
Sep 4, 2026
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-fictional-couscous
branch
2 times, most recently
from
September 4, 2026 13:46
d19ca0b to
09043a9
Compare
Extend the source dependency allowlist to every component that is currently outside the cyclic core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-fictional-couscous
branch
from
September 4, 2026 15:58
09043a9 to
5465852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCF's source dependency checker currently protects only
crypto,ds, andpal, leaving the other components outside the cyclic core free to gain new outgoing dependencies unnoticed.Extend the exact dependency allowlist to every currently acyclic source component. This covers
apps,cose,msgpack,tasks,tcp,threading,tls, andudp.appsis allowed to depend on both the syntheticccf-apicomponent andjs, matching its includes ofccf/app_interface.handccf/js/samples/governance_driven_registry.h. No checker behavior changes are required.Testing
scripts/ci-checks.sh -fTowards #3517